On Wed, Sep 14, 2016 at 02:57:04PM -0700, Eric Biggers wrote: > I agree that the return value is redundant and somewhat error prone. However, > this style is already being used for fscrypt_fname_disk_to_usr(), > fscrypt_fname_usr_to_disk(), and fname_decrypt(). My patch was primarily > intended to make things more consistent by updating fname_encrypt(), which was > the odd one out. If you'd prefer, I can instead do a patch to make all these > related functions return 0 on success, rather than a length. That would be a > somewhat larger patch. > To see more concretely what it looks like, I went ahead and wrote the "make the functions return 0" version of the patch. I'm sending it to be considered as well. In theory I think it's better, though it's a larger patch. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
