On 9/9/16 4:33 AM, norton wrote: > Hi, all > > I'm a freshman in ext4 file system and I'm reading its source code now. > This patch did nothing but make it looks better.( > some lines are too long in vim :( ). Aside from Ted's point about not taking patches which simply rewrap lines, it's worth knowing that the better practice, IMHO, when adding long text strings is not: + ext4_msg(sb, KERN_WARNING, "Remounting file " + "system with no journal so " + "ignoring journalled data option"); but: + ext4_msg(sb, KERN_WARNING, +"Remounting file system with no journal so ignoring journalled data option"); so that the strings can be found by a grep, if needed, while still avoiding 120-column lines. At least that's my time-tested opinion :) So if you ever find yourself in the position of needing to add a string like that, or are hitting it as part of other work, it's something to consider. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
