Re: [PATCH RESEND] ext4: reinforce check of i_dtime when clearing high fields of uid and gid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 22, 2016 at 02:51:25PM +0900, Daeho Jeong wrote:
> Now, ext4_do_update_inode() clears high 16-bit fields of uid/gid
> of deleted and evicted inode to fix up interoperability with old
> kernels. However, it checks only i_dtime of an inode to determine
> whether the inode was deleted and evicted, and this is very risky,
> because i_dtime can be used for the pointer maintaining orphan inode
> list, too. We need to further check whether the i_dtime is being
> used for the orphan inode list even if the i_dtime is not NULL.
> 
> We found that high 16-bit fields of uid/gid of inode are unintentionally
> and permanently cleared when the inode truncation is just triggered,
> but not finished, and the inode metadata, whose high uid/gid bits are
> cleared, is written on disk, and the sudden power-off follows that
> in order.
> 
> Signed-off-by: Daeho Jeong <daeho.jeong@xxxxxxxxxxx>
> Signed-off-by: Hobin Woo <hobin.woo@xxxxxxxxxxx>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux