On Wed, Aug 17, 2016 at 07:19:55PM +0200, Jan Kara wrote: > On Wed 17-08-16 10:11:02, Ross Zwisler wrote: > > Currently when doing a DAX hole punch with ext4 we fail to do a writeback. > > This is because the logic around filemap_write_and_wait_range() in > > ext4_punch_hole() only looks for dirty page cache pages in the radix tree, > > not for dirty DAX exceptional entries. > > > > Signed-off-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx> > > Thanks. The patch looks correct, you can add: > > Reviewed-by: Jan Kara <jack@xxxxxxx> > > Although why don't we just simplify the test below to > mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)? After all the mapping should > not have the dirty tag set if there are no pages / no entries? Sure, that works. I'll update to that in V2, and I'll add stable. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
