Hello,
Thanks for the patch. Couple of spelling fixes below and one functional
comment...
On Mon 15-08-16 16:23:35, Dmitry Monakhov wrote:
> ext4lazyinit is global thread. This thread performs itable initalization
^^^ a global thread
> under li_list_mtx mutex.
>
> It basically does following:
^ the
> ext4_lazyinit_thread
> ->mutex_lock(&eli->li_list_mtx);
> ->ext4_run_li_request(elr)
> ->ext4_init_inode_table-> Do a lot of IO if the list is large
>
> And when new mount/umount arrive they have to block on ->li_list_mtx
> because lazy_thread holds it during full walk procedure.
> ext4_fill_super
> ->ext4_register_li_request
> ->mutex_lock(&ext4_li_info->li_list_mtx);
> ->list_add(&elr->lr_request, &ext4_li_info >li_request_list);
> In my case mount takes 40minutes on server with 36 * 4Tb HDD.
> Common user may face this in case of very slow dev ( /dev/mmcblkXXX)
> Even more. If one of filesystems was frozen lazyinit_thread will simply
> blocks on sb_start_write() so other mount/umount will be suck forever.
^^^ block ^^ stuck
> This patch changes logic like follows:
> - grap ->s_umount read sem before processing new li_request.
^^^ grab
> After that it is safe to drop li_list_mtx because all callers of
> li_remove_request are holding ->s_umount for write.
> - li_thread skips frozen SB's
>
> Locking order:
> Order is asserted by umout path like follows: s_umount ->li_list_mtx so
^^^ umount
> the only way to to grab ->s_mount inside li_thread is via down_read_trylock
>
> xfstests:ext4/023
> #PSBM-49658
>
> Changes from V1
> - spell fixes according to jack@ comments
> - do not use temporal list.
>
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
> ---
> fs/ext4/super.c | 43 +++++++++++++++++++++++++++++++------------
> 1 file changed, 31 insertions(+), 12 deletions(-)
...
> + if (!progress) {
> + elr->lr_next_sched = jiffies +
> + (prandom_u32()
> + % (EXT4_DEF_LI_MAX_START_DELAY * HZ));
> }
I think we need to update next_wakeup here based on updated value of
lr_next_sched and also in case ext4_run_li_request() didn't complete the
request but ended up rescheduling it. Otherwise the patch looks fine.
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
