Hello, this patch series fixes code expanding size of inode. That code has been seriously buggy and I think it has never worked for other case than expanding legacy 128-byte inodes to larger ones. This patch series fixes all the issues I have found and passes xfstest test I have written to excercise the code. First four patches in the series fix the most serious issues leading to crashes, memory, and possibly filesystem corruption. I have tagged these for stable kernels since 4.4 (where the new inode field has been introduced and started triggering issues in the inode expansion code). The fifth patch also fixes a functional issue where we may unnecessarily fail to expand inode, or may move too many xattrs but this issue is not so serious and I don't expect it to happen too much in practice (since we usually expand only by a couple of bytes) so I didn't tag it for stable. Remaining patches in the series cleanup the code by removing bogus checks, unused variables, and factoring out the large inode expanding function into several smaller ones. Honza -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html