On Tue, Aug 02, 2016 at 08:10:47PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. I actually find using the macros significantly **decrease* the readiability of the code. A quick glance at 0644 quickly tells you what the permissions are. Parsing S_IRUSR | S_IRGRP | S_IROTH takes longer, and is more error prone. NACK. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
