On Mon, Aug 01, 2016 at 02:19:30PM +0200, Jan Kara wrote: > > Relatively simple but there are still some bugs lurking - I have the > original issue fixed but I have implemented xfstests which stress the inode > expansion code in various ways and so far they are still able to crash the > kernel... Tomorrow I will be looking more into it and hopefully will be > able to finish the fixes. Great, thanks. I'll wait and see how your patches work out. If we think all of the patches are simple/low-risk enough for -stable material, I'd much rather go with a proper fix. > Regarding your patch - I think it's a reasonable band-aid although I'll > have to backport proper fixes to 4.4 anyway (it's a base of our next > enterprise release), which is where i_projid got introduced as well, so > eventually we will have proper stable fixes for all relevant kernels > anyway. Well, it depends on whether you intend to support upgrading an existing file system or require users to run mkfs.ext4 before being able to take advantage of the new feature. Red Hat is much more conservative and has historically only supported running mke2fs from scratch --- which probably made sense from their QA department's POV, anyway. The band-aid patch is enough if you don't suppor "tune2fs -O project", but only "mke2fs -t ext4 -O project". I'd personally prefer upstream to support both flawlesssly, so I'm thankful for your work to fix things properly, but enterprise distros can be extremely conservative. Cheers, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
