On Thu 16-06-16 14:11:28, Andreas Dilger wrote: > On Jun 16, 2016, at 1:20 PM, Jan Kara <jack@xxxxxxx> wrote: > > > > Well, since ext4_mb_free_metadata() is the only user of > > ext4_journal_callback_add(), ext4_journal_callback_add() won't have any > > user after your patch. Maybe we could just stop playing these abstraction > > games nobody currently uses and just implement a helper function to add > > freeing callback to the transaction list including increment of the pending > > counter. > > We use the journal callback for Lustre servers. Please don't remove it. I didn't really mean to rewrite the callback infrastructure. I just meant to change the helper function to fit in-tree users. If Lustre needs to do something else, it is free to have its own helper function which attaches callbacks to the transaction's list. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
