On Fri 10-06-16 14:44:50, Ted Tso wrote:
> Also, if we are going to issue the barrier, we should do this after we
> write out the parent directories if necessary.
>
> Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
The patch looks good. You can add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/ext4/fsync.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
> index 8850254..5c43725 100644
> --- a/fs/ext4/fsync.c
> +++ b/fs/ext4/fsync.c
> @@ -106,9 +106,11 @@ int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
> }
>
> if (!journal) {
> - ret = generic_file_fsync(file, start, end, datasync);
> + ret = __generic_file_fsync(file, start, end, datasync);
> if (!ret && !hlist_empty(&inode->i_dentry))
> ret = ext4_sync_parent(inode);
> + if (test_opt(inode->i_sb, BARRIER))
> + goto issue_flush;
> goto out;
> }
>
> @@ -140,6 +142,7 @@ int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
> needs_barrier = true;
> ret = jbd2_complete_transaction(journal, commit_tid);
> if (needs_barrier) {
> + issue_flush:
> err = blkdev_issue_flush(inode->i_sb->s_bdev, GFP_KERNEL, NULL);
> if (!ret)
> ret = err;
> --
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
