On Thu 09-06-16 09:23:29, Nikola Pajkovsky wrote: > Holger Hoffstätte <holger@xxxxxxxxxxxxxxxxxxxxxx> writes: > > > On Wed, 08 Jun 2016 14:56:31 +0200, Jan Kara wrote: > > (snip) > >> Attached patch fixes the issue for me. I'll submit it once a full xfstests > >> run finishes for it (which may take a while as our server room is currently > >> moving to a different place). > >> > >> Honza > >> -- > >> Jan Kara <jack@xxxxxxxx> > >> SUSE Labs, CR > >> From 3a120841a5d9a6c42bf196389467e9e663cf1cf8 Mon Sep 17 00:00:00 2001 > >> From: Jan Kara <jack@xxxxxxx> > >> Date: Wed, 8 Jun 2016 10:01:45 +0200 > >> Subject: [PATCH] ext4: Fix deadlock during page writeback > >> > >> Commit 06bd3c36a733 (ext4: fix data exposure after a crash) uncovered a > >> deadlock in ext4_writepages() which was previously much harder to hit. > >> After this commit xfstest generic/130 reproduces the deadlock on small > >> filesystems. > > > > Since you marked this for -stable, just a heads-up that the previous patch > > for the data exposure was rejected from -stable (see [1]) because it > > has the mismatching "!IS_NOQUOTA(inode) &&" line, which didn't exist > > until 4.6. I removed it locally but Greg probably wants an official patch. > > > > So both this and the previous patch need to be submitted. > > > > [1] http://permalink.gmane.org/gmane.linux.kernel.stable/18074{4,5,6} > > I'm just wondering if the Jan's patch is not related to blocked > processes in following trace. It very hard to hit it and I don't have > any reproducer. This looks like a different issue. Does the machine recover itself or is it a hard hang and you have to press a reset button? Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
