On Thu 12-05-16 13:36:24, Ross Zwisler wrote:
> On Thu, May 12, 2016 at 06:29:18PM +0200, Jan Kara wrote:
> > @@ -897,13 +1166,10 @@ int __dax_pmd_fault(struct vm_area_struct *vma, unsigned long address,
> > * the write to insert a dirty entry.
> > */
> > if (write) {
> > - error = dax_radix_entry(mapping, pgoff, dax.sector,
> > - true, true);
> > - if (error) {
> > - dax_pmd_dbg(&bh, address,
> > - "PMD radix insertion failed");
> > - goto fallback;
> > - }
> > + /*
> > + * We should insert radix-tree entry and dirty it here.
> > + * For now this is broken...
> > + */
>
> With this change the 'error' variable in __dax_pmd_fault() is now unused,
> resulting in a compiler warning.
>
> fs/dax.c: In function ‘__dax_pmd_fault’:
> fs/dax.c:1019:6: warning: unused variable ‘error’ [-Wunused-variable]
> int error, result = 0;
> ^
I didn't want to respin the patch set because of this but I'll send a fixup
patch for it.
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
