On Apr 15, 2016, at 7:13 PM, Theodore Ts'o <tytso@xxxxxxx> wrote:
>
> If the UUID field is NULL, e2fsck will try to generate and set a new
> UUID. This will cause massive problems if the metadata_csum feature
> is set, so avoid doing so in that case.
Should enabling the metadata csum feature complain/fail if the checksum
is unset? It doesn't make sense to use a NULL UUID as the checksum salt.
Cheers, Andreas
> Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
> ---
> e2fsck/super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/e2fsck/super.c b/e2fsck/super.c
> index e09c14c..dec70bd 100644
> --- a/e2fsck/super.c
> +++ b/e2fsck/super.c
> @@ -756,6 +756,7 @@ void check_super_block(e2fsck_t ctx)
> * if the id changes under the kernel remounting rw may fail.
> */
> if (!(ctx->options & E2F_OPT_READONLY) && uuid_is_null(sb->s_uuid) &&
> + !ext2fs_has_feature_metadata_csum(ctx->fs->super) &&
> (!csum_flag || !(ctx->mount_flags & EXT2_MF_MOUNTED))) {
> if (fix_problem(ctx, PR_0_ADD_UUID, &pctx)) {
> uuid_generate(sb->s_uuid);
> --
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers, Andreas
Attachment:
signature.asc
Description: Message signed with OpenPGP using GPGMail
