Re: GETNEXTQUOTA causes kernel crash if quota not enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon 28-03-16 00:43:39, Ted Tso wrote:
> Hi Jan, this looks like a recent change that just landed in the quota
> tree.  The crash is in dquot_get_next_id() because
> sb_dqopt(sb)->ops[0] is NULL.
> 
> This looks like it was introduced in a fairly recent commit:
> be6257b251ce ("quota: Add support for ->get_nextdqblk() for VFS
> quota").
> 
> Please see reproduction below.  It can also be easily reproduced using
> "kvm-xfstests -c encrypt generic/244")

Thanks for report! Obviously we are missing a test whether quota is
actually enabled for the filesystem (the test generic/244 seems to be
somewhat buggy for VFS quota based filesystems). It was not written yet
when I was testing my changes and it never occured to me to run
Q_GENTEXTQUOTA against a filesystem with quotas disabled... I'll fix it up.

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux