On Thu, Mar 24, 2016 at 4:17 PM, Vishal Verma <vishal.l.verma@xxxxxxxxx> wrote:
> From: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
>
> dax_clear_sectors() cannot handle poisoned blocks. These must be
> zeroed using the BIO interface instead. Convert ext2 and XFS to use
> only sb_issue_zerout().
>
> Signed-off-by: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
> [vishal: Also remove the dax_clear_sectors function entirely]
> Signed-off-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>
> ---
> fs/dax.c | 32 --------------------------------
> fs/ext2/inode.c | 7 +++----
> fs/xfs/xfs_bmap_util.c | 9 ---------
> include/linux/dax.h | 1 -
> 4 files changed, 3 insertions(+), 46 deletions(-)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index bb7e9f8..a30481e 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -78,38 +78,6 @@ struct page *read_dax_sector(struct block_device *bdev, sector_t n)
> return page;
> }
>
> -/*
> - * dax_clear_sectors() is called from within transaction context from XFS,
> - * and hence this means the stack from this point must follow GFP_NOFS
> - * semantics for all operations.
> - */
> -int dax_clear_sectors(struct block_device *bdev, sector_t _sector, long _size)
> -{
> - struct blk_dax_ctl dax = {
> - .sector = _sector,
> - .size = _size,
> - };
> -
> - might_sleep();
> - do {
> - long count, sz;
> -
> - count = dax_map_atomic(bdev, &dax);
> - if (count < 0)
> - return count;
> - sz = min_t(long, count, SZ_128K);
> - clear_pmem(dax.addr, sz);
> - dax.size -= sz;
> - dax.sector += sz / 512;
> - dax_unmap_atomic(bdev, &dax);
> - cond_resched();
> - } while (dax.size);
> -
> - wmb_pmem();
> - return 0;
> -}
> -EXPORT_SYMBOL_GPL(dax_clear_sectors);
What about the other unwritten extent conversions in the dax path?
Shouldn't those be converted to block-layer zero-outs as well?
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
