On Wed, Mar 23, 2016 at 11:25:31AM +0800, Eryu Guan wrote: > On Wed, Mar 23, 2016 at 01:53:27PM +1100, Dave Chinner wrote: > > On Tue, Mar 15, 2016 at 04:12:14PM +0800, Eryu Guan wrote: > > > This is a test that performs simple I/O on dm error device, which > > > returns EIO on all I/O request. > > > > > > This is motivated by an ext4 bug that crashes kernel on error path when > > > trying to update atime. Following kernel patch should fix the issue > > > > > > ext4: fix NULL pointer dereference in ext4_mark_inode_dirty() > > > > > > Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx> > > > --- > > > > Fails with: > > > > @@ -1,2 +1,6 @@ > > QA output created by 338 > > Silence is golden > > +specified blocksize 1024 is less than device physical sector size 4096 > > +switching to logical sector size 512 > > +mkfs.xfs: /dev/mapper/error-test appears to contain an existing filesystem (xfs). > > +mkfs.xfs: Use the -f option to force overwrite. > > > > And then it failed to clean up properly and caused all sorts of > > subsequent problems. > > Test passed for me, seems it has something to do with the "physical > sector size 4096" device. I'll look into it. Thanks for the review! It fails because "_mkfs_dev $DMERROR_DEV" refuses to create new fs without "-f" option, has nothing to do with the 4k sector device. It passed for me is because I add "-f" mkfs option to my local.config for xfs sections, so _mkfs_dev passed. I'll send v3 to fix this. And the test fails to do cleanups on failure because "dmsetup remove error-test" reports device is busy. Adding a "$UDEV_SETTLE_PROG" call before "dmsetup remove error-test" in common/dmerror fixes the issue for me. I'll send another patch to fix it. Thanks, Eryu -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
