On Sun, Mar 06, 2016 at 01:14:51PM +0900, Li Xi wrote: > Project quota need use some extra field of inode for computing quota > accounting, this patch tries to use ext2fs_get_next_inode_full() > everywhere to read full inode into memeory. > > It also fixes a bug that only copy small inode in the function. > > Signed-off-by: Wang Shilong <wshilong@xxxxxxx> Um, no. Most of the places where we are currently using ext2fs_get_next_inode() is because they **don't** need the full inode. For example, consider debugfs's icheck command. Why would it need the project quota id? Answer: it doesn't. If you think there is a bug, or some place where we should be using the large inode, fine. Let's take a look at it. But doing a whole sale conversion of ext2fs_get_next_inode() to ext2fs_get_next_inode_full() makes e2fsprogs much less efficient, and for no good purpose. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
