On Mon, Feb 22, 2016 at 09:19:14AM +0100, Jan Kara wrote: > On Sun 21-02-16 17:28:26, Dave Chinner wrote: > > On Fri, Feb 19, 2016 at 02:18:29PM +0100, Jan Kara wrote: > > > On Fri 19-02-16 09:02:32, Dave Chinner wrote: > > > > Won't that now call ext4_put_io_end() -> > > > > ext4_convert_unwritten_extents() with an uninitialised offset and > > > > size? > > > > > > > > i.e. I don't think this prevents warnings, and may make things > > > > worse when real errors occur.... > > > > > > Yeah, if IO error occurs while writing to unwritten extent we need to just > > > destroy the IO end without doing the extent conversion (since we don't know > > > how much got written). Attached patch should fix the issue - full xfstests > > > run is in progress but a quick check using generic/299 has passed. > > > > > > How do we merge this? It depends on the changes in Dave's tree so do we > > > merge it via that? I have other ext4 changes pending in this area so Ted > > > would then have to pull some branch from Dave's tree. Guys? > > > > The xfs-dio-fix-4.6 branch in the XFS tree is stable, so feel free > > to pull it into other trees. However, it might be better for me to > > append this patch to that branch once it is revewed and tested to > > keep them all together in a stable branch. It can still be pulled > > into other trees if needed... > > Full xfstests run completed for me fine with the patch so it should be > good to go in your tree in that regard. So additional review would be fine > though. Darrick, can you have a look? Looks good to me and passes generic/25[02], so Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D > > Honza > -- > Jan Kara <jack@xxxxxxxx> > SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
