On Sat, 2016-02-13 at 14:38 -0800, Darrick J. Wong wrote: > Richard Purdie reports that libext2fs doesn't sort attribute keys in > the xattr block correctly, causing the kernel to return -ENODATA when > querying attributes that should be there. Therefore, sort attributes > so that whatever ends up in the xattr block is sorted according to > what the kernel expects. > > Cc: Darren Hart <dvhart@xxxxxxxxxxxxxxx> > Reported-by: Richard Purdie <richard.purdie@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > lib/ext2fs/ext_attr.c | 24 +++++++++++- > tests/d_xattr_sorting/expect | 29 ++++++++++++++ > tests/d_xattr_sorting/name | 1 > tests/d_xattr_sorting/script | 86 > ++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 139 insertions(+), 1 deletion(-) > create mode 100644 tests/d_xattr_sorting/expect > create mode 100644 tests/d_xattr_sorting/name > create mode 100644 tests/d_xattr_sorting/script I had some test scripts I'd used to debug this. I applied this patch and those tests passed, thanks! Tested-by: Richard Purdie <richard.purdie@xxxxxxxxxxxxxxxxxxx> I'll update the version of this we're using in OpenEmbedded and the Yocto Project to your patch. Cheers, Richard -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
