On 1/14/16 12:50 PM, Darrick J. Wong wrote: > On Thu, Jan 14, 2016 at 12:46:03PM -0600, Eric Sandeen wrote: ... >> diff --git a/lib/ext2fs/ext2fs.h b/lib/ext2fs/ext2fs.h >> index 86d860f..0dca002 100644 >> --- a/lib/ext2fs/ext2fs.h >> +++ b/lib/ext2fs/ext2fs.h >> @@ -647,6 +647,7 @@ static inline int ext2fs_needs_large_file_feature(unsigned long long file_size) >> } >> >> /* alloc.c */ >> +extern void clear_block_uninit(ext2_filsys fs, dgrp_t group); > > If you're going to expose this as a new API call then this needs to be > ext2fs_clear_block_uninit(). Hm, yes. I tried to work around it but don't see a nice way. > (Do we want a flags arg just in case we ever need one?) No. ;) (EXT2_CLEAR_GROUP_UNINIT_HALFWAY? I can't really think of any reasonable variation on "clear this group's uninit status") -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
