On Tue, 2015-11-24 at 14:34 -0700, Andreas Dilger wrote: > +static int check_inode_extra_negative_epoch(__u32 xtime, __u32 > extra) { > + return (xtime & (1 << 31)) != 0 && On a re-read, I think the bitshift is technically undefined behavior because 1 is signed and 2**31 is not representable as a signed (32-bit) int. Changing it to 1U should fix it. Other than that, LGTM. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html