Now, in ext4, there is only one writepages() function and it is shared by all the inode modes. Therefore, BUG_ON() for checking journaled inode mode in ext4_writepages() is not correct anymore because, if per-file data journaling of a file is enabled while ext4_writepages() is being executed, this BUG_ON() function can cause a kernel panic unintentionally even on "nodelalloc" mode. Signed-off-by: Daeho Jeong <daeho.jeong@xxxxxxxxxxx> --- fs/ext4/inode.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 1f9458e..db24348 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -2480,13 +2480,11 @@ retry: } /* - * We have two constraints: We find one extent to map and we + * We have a constraint: We find one extent to map and we * must always write out whole page (makes a difference when * blocksize < pagesize) so that we don't block on IO when we - * try to write out the rest of the page. Journalled mode is - * not supported by delalloc. + * try to write out the rest of the page. */ - BUG_ON(ext4_should_journal_data(inode)); needed_blocks = ext4_da_writepages_trans_blocks(inode); /* start a new transaction */ -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
