On Fri, Nov 13, 2015 at 06:10:28PM -0700, Andreas Dilger wrote: > If ext2fs_punch() is called with "end = ~0U" (which is natural from > a programming POV) it tries to compute "count" based on "start" and > "end", but doesn't quite get it right. You should make clear that this only applies in the case where we are punching on an indirect block mapped file. I read this and alarm bells started going off since end is a blk64_t, and we can't do this for extent-mapped files. > Pass "count=~0" > in this case, and also handle that explicitly in ext2_punch_ind(). > Since ext2_punch_ind() is itself a public function, so it makes > sense to fix this in both places. Um, ext2fs_punch()_ind is *not* a public function. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
