On Sat, Nov 7, 2015 at 5:25 PM, Jason Pepas <jasonpepas@xxxxxxxxx> wrote: > On Sat, Nov 7, 2015 at 5:20 PM, Richard W.M. Jones <rjones@xxxxxxxxxx> wrote: >> >> I'll leave the rest to the true experts on the ext4 mailing list. > > Thanks for you help! I'll move the rest of this discussion to their > mailing list. Hi ext4 folk, I ran into a situation where mke2fs was writing to faulty block device (an nbd server), but mke2fs didn't report a problem, so I didn't know that my newly created filesystem was corrupted. I've traced this down to the return value not being checked on the final fsync() call. I've confirmed locally that checking this return value and passing it up the call stack will correctly cause mke2fs to exit non-zero. I've created a pull request on github here: https://github.com/tytso/e2fsprogs/pull/4 Thanks, Jason Pepas -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
