On Sun, Nov 01, 2015 at 06:16:50PM -0700, Andreas Dilger wrote: > Is there a reason not to have a cancel check right after the return from > e2fsck_run() rather than trying to recover the journal and quota files? > I can imagine that there is a desire to flush out modified inodes and such > that have been repaired, so that restarting an interrupted e2fsck will make > progress, but the quota file update is plain wrong unless at least pass1 > has finished, and the journal recreation is also dangerous if the block > bitmaps have not been fully updated. You're right. My suggested fix would be in the case of E2F_FLAG_CANCEL, we set the ctx->invalid_bitmaps flag, and then avoid writing out the quota file if invalid_bitmaps is enabled. Cheers, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
