On Thu, Oct 15, 2015 at 10:37:28AM -0400, Theodore Ts'o wrote: > On Mon, Oct 12, 2015 at 02:54:37PM -0700, Darrick J. Wong wrote: > > The ext2 mount code never checks the compat features against the ones > > it knows about. This is correct behavior since compat features are > > supposed to be rw-compatible with old drivers; however, for certain > > configurations (journalled rootfs) the admin is unlikely to want > > no-journal mode. Since we changed the default probe order to put ext4 > > first, we can make ext2.ko only allow readonly mounts if has_journal is > > found. > > > > (Remember, this only affects mounting ext3 filesystems on ext2.ko.) > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > I'm not sure that we need this patch. If someone explicitly requests > a r/w mount of an ext3 file system using ext2, we should let it. > After changing the default probe order, the only time your change > would prohibit the mounting of an ext3 file system is when the system > administrator has explicitly mentioned the file system type in command > line. Okay, let's drop it then. --D > > - Ted > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
