Re: [PATCH 13/19] tune2fs: Add support for changing number of reserved inodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat 08-08-15 10:45:00, Alexey Lyashkov wrote:
> 
> > On Aug 7, 2015, at 1:51 PM, Jan Kara <jack@xxxxxxxx> wrote:
> > 
> > Signed-off-by: Jan Kara <jack@xxxxxxxx>
> > ---
> > 
> > +			new_first_ino = strtoul(arg, &p, 0);
> > +			if (*p) {
> > +				fprintf(stderr,
> > +					_("Invalid number of reserved inodes "
> > +					  "%s\n"),
> > +					arg);
> > +				r_usage++;
> > +				continue;
> > +			}
> > 
> 
> this check invalid - you need check an errno for ERANGE also. 
> add check against maximal number inodes on FS is also good.

Good point. Added both checks.

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux