Re: [PATCH] ext4: fix fencepost error in lazytime optimization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Theodore Ts'o wrote on 07/02/2015 05:38:
> Commit 8f4d8558391: "ext4: fix lazytime optimization" was not a
> complete fix.  In the case where the inode number is a multiple of 16,
> and we could still end up updating an inode with dirty timestamps
> written to the wrong inode on disk.  Oops.
> 
<snip>
> -	ino = (orig_ino & ~(inodes_per_block - 1)) + 1;
> +	ino = ((orig_ino - 1) & ~(inodes_per_block - 1)) + 1;

Maybe, a comment stating what should be accomplished here would help?
-- 
Regards,
Jörg.


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux