On Mon 15-06-15 15:47:04, Theodore Ts'o wrote: > On Mon, Jun 15, 2015 at 04:17:34PM +0200, Michal Hocko wrote: > > insert_revoke_hash does an open coded endless allocation loop if > > journal_oom_retry is true. It doesn't implement any allocation fallback > > strategy between the retries, though. The memory allocator doesn't know > > about the never fail requirement so it cannot potentially help to move > > on with the allocation (e.g. use memory reserves). > > > > Get rid of the retry loop and use __GFP_NOFAIL instead. We will lose the > > debugging message but I am not sure it is anyhow helpful. > > > > Do the same for journal_alloc_journal_head which is doing a similar > > thing. > > > > Signed-off-by: Michal Hocko <mhocko@xxxxxxx> > > Thanks, applied. Thanks! -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
