On Mon, Jun 15, 2015 at 07:03:25PM +0200, Jan Kara wrote: > I think that fully switching lock ordering for data=journal mode back to > page lock -> transaction start (which is what you effectively do when you > never drop page lock in ->writepage) is rather error prone. We'd have to be > careful to avoid lock inversion also for places like ->write_begin, > ->releasepage, ->invalidatepage etc. For example ext4_write_begin() will > currently call lock_page() with transaction started which could deadlock > against journalled writepage you suggest. So effectively we'd have to > completely separate aops for data=journal mode. Doable but I'm not sure > it's worth it. Good point. OTOH, things are kind of fragile with respect to ext4_write_begin() in data=journal mode, as you've pointed out. But it's not causing any problems as far as we know, so so I'll use the patch which you ack'ed and maybe later on, we can figure out a better way to clean this up. Thanks, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
