On Sat, Jun 06, 2015 at 04:20:11PM -0400, Theodore Ts'o wrote: > On Tue, Jun 02, 2015 at 10:08:18AM +0200, Lukáš Czerner wrote: > > On Tue, 19 May 2015, Josef Bacik wrote: > > > > > Date: Tue, 19 May 2015 11:28:57 -0400 > > > From: Josef Bacik <jbacik@xxxxxx> > > > To: tytso@xxxxxxx, linux-ext4@xxxxxxxxxxxxxxx > > > Subject: [PATCH] ext4: only call ext4_truncate when size <= isize > > > > > > At LSF we decided that if we truncate up from isize we shouldn't trim fallocated > > > blocks that were fallocated with KEEP_SIZE and are past the new i_size. This > > > patch fixes ext4 to do this. Thanks, > > > > Looks good, thanks! > > > > Reviewed-by: Lukas Czerner <lczerner@xxxxxxxxxx> > > Applied, thanks. Unfortunately this patch is causing generic/239 to fail when run with 1k blocksizes. I'm dropping this for now; could you take a look? Thanks! - Ted generic/239 22s ... [11:46:25] [11:46:54] 29s _check_generic_filesystem: filesystem on /dev/vdd is inconsistent (see /results/results-1k/generic/239.full) Ran: generic/239 Failures: generic/239 Failed 1 of 1 tests e2fsck 1.43-WIP (18-May-2015) Pass 1: Checking inodes, blocks, and sizes Inode 12, i_size is 0, should be 4096. Fix? yes Pass 2: Checking directory structure Pass 3: Checking directory connectivity Pass 4: Checking reference counts Pass 5: Checking group summary information /dev/vdd: ***** FILE SYSTEM WAS MODIFIED ***** /dev/vdd: 12/327680 files (0.0% non-contiguous), 120145/5242880 blocks -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html