On Mon 25-05-15 10:16:27, Andreas Dilger wrote:
>
> > On May 25, 2015, at 1:38 AM, Jan Kara <jack@xxxxxxx> wrote:
> >
> > On Fri 22-05-15 10:18:42, Darrick J. Wong wrote:
> >> On Fri, May 22, 2015 at 01:28:57PM +0200, Jan Kara wrote:
> >>> @@ -1970,6 +2011,31 @@ static int parse_extended_opts(ext2_filsys fs, const char *opts)
> >>> continue;
> >>> }
> >>> ext_mount_opts = strdup(arg);
> >>> + } else if (!strcmp(token, "orphan_file_size")) {
> >>> + __u64 size;
> >>> +
> >>> + if (!arg) {
> >>> + r_usage++;
> >>> + continue;
> >>> + }
> >>> + size = strtoul(arg, &p, 0);
> >>
> >> Would be nice if I could supply units, e.g. orphan_file_size = 128K here.
> >
> > I don't mind doing this but do we have precedens in any option? Because
> > e.g. journal size is just a number (in megabytes), stripe options are in fs
> > blocks. For orphan file megabytes are too coarse. I can make the unit
> > fs-blocks, or kbytes, or leave it at bytes, or allow specifying units but
> > some consistency would be good. Any opinion?
>
> Use "parse_num_blocks2()" for this. This is used to parse the filesystem size in mke2fs,
> blocksize, bigalloc cluster size, resize, etc. You are right that the journal_size is
> NOT using this helper, but it probably should.
Ah, thanks for the hint! Will do.
Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
