On Tue, May 05, 2015 at 09:54:36AM +0200, Jan Kara wrote: > > Coverity complains about the new ext4 crypto code. The complaint is that > ext4_fname_crypto_alloc_buffer() and ext4_fname_crypto_namelen_on_disk() > check for ctx being NULL but they dereference it before that check. > I've checked and didn't find callers that would actually pass NULL into > these functions so do we want to remove the unused check or move the > dereference? I think it would be worth cleaning up just that we don't fall > into the trap sometime later... I'm going to be posting a performance patch shortly that drops ext4_fname_crypto_ctx entirely (and with it those checks, obviously). So that should take care of that. Cheers, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
