On Sun, May 03, 2015 at 05:11:18PM -0400, Theodore Ts'o wrote: > > Thanks for pointing out problem in the commit message. I guess I > wasn't reading all that carefully, but started experimenting, and came > up with some case where, if they aren't lack _bugs_, do constrain > flexibility a little. You are correct that various crypto modules can > still be built as modules even if ext4 is a module and > EXT4_FS_ENCRYPTION is 'y'. The main issue that I was able to find is > that if ext4 is _not_ a module, then it also forces the crypto modules > to also be built in. Sorry for the confusion. Please just revert my patch. I was trying to figure out what was causing various crypto modules to be built-in in my test config and this was the latest change that *looked* as if it might have caused my problem. Obviously I didn't test it properly after making that change. It should just be reverted because if ext4 was built-in then you do want to have the crypto stuff built-in just in case the root fs was encrypted. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
