On Mon, Apr 20, 2015 at 09:43:45PM -0700, Darrick J. Wong wrote: > On Mon, Apr 20, 2015 at 10:26:45PM -0400, Theodore Ts'o wrote: > > On Wed, Apr 01, 2015 at 07:34:33PM -0700, Darrick J. Wong wrote: > > > Use a bitmap to track which directories we want to rehash, since > > > bitmaps will use less memory. This enables us to clean up the > > > rehash-all case to use inode_dir_map, and we can free the dirinfo > > > memory sooner. > > > > Using inode_dir_map for the rehash-all case is a good idea, but I'm > > not sure it follows that we should ues a bitmap for the non-rehash-all > > case. > > Eh, you're right, let's drop this one. Honestly it's been so long I don't > remember my motivation for writing this up in the first place. Thanks for > pulling in the e2fsck readahead pieces, though! I think there still is value in using inode_dir_map to iterate over all of the directories, so we can free the dirinfo memory sooner, but the value is not as great, I agree. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
