Hi Ted, It's my fault. I didn't properly check the case of having data = NULL to kstrdup() as my system has long mounting options.. Sorry for the trouble. I think there is no clean way to handle this error (better), other than implicitly letting kstrdup() fail (and ignore). Taesoo On 04/03/15 at 01:09am, Theodore Ts'o wrote: > On Fri, Mar 20, 2015 at 05:21:54PM -0400, Taesoo Kim wrote: > > Upon memory pressure, kstrdup() might fail and correctly > > handle memory error, although current implementation do not > > refer orig_data. > > > > NOTE. fortunately the correct impl works, other than a > > corner case where kstrdup() fails and kzalloc() succeeds; > > it might record 'NULL' in the log. > > > > Signed-off-by: Taesoo Kim <tsgatesv@xxxxxxxxx> > > Did you test this patch? If there are no mount options (such as when > mounting the root file system, data is NULL, so orig_data is NULL), > and the mount fails. So a kernel won't boot with this patch applied. > > - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
