On Mon, Jan 26, 2015 at 11:36:06PM -0800, Darrick J. Wong wrote: > Use qsort to move the inlinedata attribute to the front of the list > and the empty entries to the end. Then we can use handle->count to > decide if we're done writing xattrs, which helps us to avoid the > situation where we're midway through the attribute list, so we > allocate an EA block to store more, but have no idea that there's > actually nothing left in the list. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Applied, although I wonder if we might want to be a bit more sophisticated about how we handle the order of attributes in the future. In particular, if we need to spill over into an EA block, there are certain things like the selinux security id that we would want to be inline in the inode, and let other xattrs spill over into the EA block. And of course, if we can manage to fit all of the xattrs into the inode, except for system.data, then we should bail on using the inline data feature at all, and just allocate a normal data block for the data, and not use an EA block for system.data at all. It's much more imporant that we get this sort of stuff right for the kernel implementation, though, and if we occasionally misoptimize things in libext2fs, that's unfortunate, but it's primarily going to be a problem for the FUSE driver... - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
