On 11/13/14 3:16 PM, Steve French wrote: > I see an earlier thread about ext4 defrag problems causing this > failure on xfstest generic/018 running on ext4 > > generic/018 1s ... [failed, exit status 1] - output mismatch (see > /home/sfrench/xfstests/results//generic/018.out.bad) > --- tests/generic/018.out 2014-11-13 11:20:05.385406288 -0800 > +++ /home/sfrench/xfstests/results//generic/018.out.bad 2014-11-13 > 12:33:19.317806287 -0800 > @@ -10,10 +10,5 @@ > After: 1 > Write backwards sync, but contiguous - should defrag to 1 extent > Before: 10 > -After: 1 > -Write backwards sync leaving holes - defrag should do nothing > -Before: 16 > -After: 16 > ... > > but wasn't clear whether it was fixed upstream. It failed on two out > of three runs for me on most current ext4. My test is on most current > Ubuntu x86_64 (and with 3.18-rc3 kernel) > I couldn't find version info for e4defrag from the command line but > other ext4 tools are reasonably recent it seems as Ubuntu packages > them e.g. EXT2FS Library version 1.42.10, 18-May-2014 > > Is generic xfstest 18 still broken on ext4? Did you try upstream? When I test upstream, it passes. Because: # git log --oneline v1.42.10.. misc/e4defrag.c c7c539e e4defrag: backwards-allocated files should be defragmented too 47fee2e e2fsprogs: introduce ext2fs_close_free() helper So no, it is not still broken. > Also am curious about test generic/026 > > generic/026 [not run] ext4 does not define maximum ACL count > > Is that expected? in common/attr: # filesystems that want to test maximum supported acl counts need to # add support in here _acl_get_max() ... Because ext4 has not added support there, yes, it is expected that it will not run. ;) I don't honestly know if ext4 has an upper limit on acls. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html