On Tue, Nov 11, 2014 at 10:04:18PM +0100, Jan Kara wrote: > Split ->set_xstate callback into two callbacks - one for turning quotas > on (->sysquota_on) and one for turning quotas off (->sysquota_off). That > way we don't have to pass quotactl command into the callback which seems > cleaner. Yes, I much prefer these to be split. But the names seem a little odd, why not enable_quota/disable_quota? > +static unsigned int generic_to_xfs_flags(unsigned int uflags) xfs_quota_flags() ? -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html