Re: [PATCH 06/34] debugfs: add LIBINTL to debugfs link command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 17, 2014 at 02:07:37PM -0700, Darrick J. Wong wrote:
> 
> True, but since debugfs pulls in plausible.o which uses _(), it still needs
> this patch to build on OSX 10.9.5.

Good point.  I'l fix it this way.  (Basically, it's really pointless
to link debugfs with LIBINTL since debugfs doesn't have any I18N
support, and I'd prefer to limit unnecessary bloat.)

	     	 	   	 	     - Ted

commit 831aa869e8b1b287ca921e7ae181a4cdca839099
Author: Theodore Ts'o <tytso@xxxxxxx>
Date:   Sat Oct 18 09:13:09 2014 -0400

    debugfs: fix build on systems that don't have gettext built-in
    
    Debugfs (unlike all of the other programs in e2fsprogs) is not set up
    to use translated strings.  So when building misc/plausible.c for
    debugfs, we need to disable NLS.
    
    Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>

diff --git a/misc/nls-enable.h b/misc/nls-enable.h
index a91dcc1..2f62c01 100644
--- a/misc/nls-enable.h
+++ b/misc/nls-enable.h
@@ -1,4 +1,4 @@
-#ifdef ENABLE_NLS
+#if defined(ENABLE_NLS) && !defined(DEBUGFS)
 #include <libintl.h>
 #include <locale.h>
 #define _(a) (gettext (a))
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux