On Sat, Sep 13, 2014 at 03:12:53PM -0700, Darrick J. Wong wrote: > +#if defined(HAVE_FALLOCATE) && defined(FALLOC_FL_ZERO_RANGE) > + int flag = FALLOC_FL_ZERO_RANGE; > + struct stat statbuf; > + > + /* > + * If we're trying to zero a range past the end of the file, > + * just use regular fallocate to get there, because zeroing > + * a range past EOF does not extend the file. > + */ If we are operating on a regular file (for example, "mkfs.ext4 /tmp/foo.img 64M") we want to keep the file a sparse one; so if we are trying to zero a range past the end of the file, it should be sufficient simply use trucate to set i_size. In fact, if we can use FALLOC_FL_PUNCH on the regular file, we should try to use that instead, I would think. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html