On Sep 18, 2014, at 2:26 PM, Theodore Ts'o <tytso@xxxxxxx> wrote: > Through an oversight, when we added nojournal support to ext4, we > didn't add support to allow file system freezing. This is relatively > easy to add, so let's do it. > > Signed-off-by: Theodore Ts'o <tytso@xxxxxxx> > Reported-by: Dexuan Cui <decui@xxxxxxxxxxxxx> > --- > fs/ext4/super.c | 27 ++++++++++++++++----------- > 1 file changed, 16 insertions(+), 11 deletions(-) > > @@ -4758,23 +4760,26 @@ static int ext4_freeze(struct super_block *sb) > > journal = EXT4_SB(sb)->s_journal; [snip] > /* Journal blocked and flushed, clear needs_recovery flag. */ > EXT4_CLEAR_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER); > error = ext4_commit_super(sb, 1); > out: > - /* we rely on upper layer to stop further updates */ > - jbd2_journal_unlock_updates(EXT4_SB(sb)->s_journal); > + if (journal) > + /* we rely on upper layer to stop further updates */ > + jbd2_journal_unlock_updates(EXT4_SB(sb)->s_journal); This could use "journal" directly instead of "EXT4_SB(sb)->s_journal" Cheers, Andreas
Attachment:
signature.asc
Description: Message signed with OpenPGP using GPGMail
