On Thu, 18 Sep 2014, Dmitry Monakhov wrote: > Date: Thu, 18 Sep 2014 13:30:36 +0400 > From: Dmitry Monakhov <dmonakhov@xxxxxxxxxx> > To: Lukáš Czerner <lczerner@xxxxxxxxxx>, Theodore Ts'o <tytso@xxxxxxx> > Cc: linux-ext4@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/2] ext4: Explicitly inform user about orphan list > cleanup. > > On Thu, 18 Sep 2014 10:49:56 +0200 (CEST), Lukáš Czerner <lczerner@xxxxxxxxxx> wrote: > > On Thu, 18 Sep 2014, Theodore Ts'o wrote: > > > > > Date: Thu, 18 Sep 2014 00:29:07 -0400 > > > From: Theodore Ts'o <tytso@xxxxxxx> > > > To: Dmitry Monakhov <dmonakhov@xxxxxxxxxx> > > > Cc: linux-ext4@xxxxxxxxxxxxxxx > > > Subject: Re: [PATCH 2/2] ext4: Explicitly inform user about orphan list > > > cleanup. > > > > > > On Sun, Sep 14, 2014 at 04:38:57PM +0400, Dmitry Monakhov wrote: > > > > Production fs likely compiled/mounted w/o jbd debugging, so orphan list clearing > > > > will be silent. > > > > > > > > Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx> > > > > > > Thanks, applied. > > > > Hmm did not we just take this out recently with > > > > 566370a2e56837be98bc62d012fc2d2d11851db4 ext4: suppress ext4 orphan > > messages on mount > The message I want to change appears only if file system contains > errors. So IMHO this is reasonable to make this message louder. > This is important because after orphan list will be directly cleared > later fsck will complain about incorrect dtime and corrupted orphan list. > Sane administrator should investigate why this happen. So leaving > precise message in /var/log/messages is good practice from our side. Ah, yes. It's for the file system with errors so it is fine. I spoke too soon, sorry about that. Thanks! -Lukas > > > > and TBH I like it that way. > > > > Thanks! > > -Lukas > > > > > > > > - Ted > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > >
