[cc linux-ext4] On Fri, Sep 12, 2014 at 10:09:55AM -0400, TR Reardon wrote: > Note that this only works (zeroes out) when removing inode journal. Removing > an existing journal_dev leaves s_jnl_blocks untouched. To be absolutely > clean, perhaps it should be wiped in all removal cases? s_jnl_blocks shouldn't be set if an external journal is in use. (Unless it is somehow?) --D > > --- Original Message --- > > From: "Theodore Ts'o" <tytso@xxxxxxx> > Sent: September 11, 2014 12:44 PM > To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> > Cc: linux-ext4@xxxxxxxxxxxxxxx, "TR Reardon" <thomas_reardon@xxxxxxxxxxx> > Subject: Re: [PATCH 09/25] misc: zero s_jnl_blocks when removing internal journal > > On Mon, Sep 08, 2014 at 04:12:35PM -0700, Darrick J. Wong wrote: > > When we're removing the internal journal (broken journal, turning it > > off, or adding an external journal), zero s_jnl_blocks so that they > > can't be picked up by accident later. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Cc: TR Reardon <thomas_reardon@xxxxxxxxxxx> > > Applied, thanks. > > - Ted > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
