On Thu, Sep 11, 2014 at 04:07:58PM -0700, Darrick J. Wong wrote:
> On Thu, Sep 11, 2014 at 06:52:23PM -0400, Theodore Ts'o wrote:
> > On Thu, Sep 11, 2014 at 03:50:22PM -0700, Darrick J. Wong wrote:
> > >
> > > Looks like most everything landed ok except for:
> > >
> > > Yikes, make check explodes:
> >
> > Hmm, works for me. Could you make sure you've done a "make clean" and
> > also a "git clean"? In particular, make sure you don't have a
> > leftover file in debugfs/jfs_user.h....
>
> There aren't any stray jfs_user.h files, but rearranging DEBUGFS_CFLAGS seems
> to fix it. On Ubuntu 14.04 it seems that the compile command for
> lib/ext2fs/journal.o is:
>
> gcc -I. -I../../lib -I../../lib -Wall -g -O2 -fstack-protector --param=ssp-buffer-size=4 -DHAVE_CONFIG_H -I./../../e2fsck -DDEBUGFS -c ../../debugfs/journal.c -o journal.o
Ah, now I see why it works for me. I was using a VPATH build
directory, so it wasn't finding the one in lib/ext2fs/jfs_user.h. But
you're probably building in the source directory, so it was finding it
via "-I.".
Your patch looks good, thanks. I'll apply it and push out an update.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
