On Wed, Sep 10, 2014 at 04:30:41PM -0400, TR Reardon wrote: > When running tune2fs -O ^metadata_csum, disable_uninit_bg() is called to > reset the gdt. However, return value is not checked, which allows a failure > (say, a block bitmap failure somewhere, among other errors) to continue > through to rewrite_metadata_checksums() > > This seems wrong; should not the rewrite occur only if > disable/enable_uninit_bg() succeeds? The rewrite will fail if either of the error cases in disable_uninit_bg() fail, since rewrite_metadata_checksums() also tries to load the bitmap and scan the inodes. However, I wouldn't want to guarantee that in perpetuity, so let's check the error codes anyway. --D > > +Reardon -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
