On Sun, Sep 07, 2014 at 08:29:02AM -0400, Theodore Ts'o wrote: > Using "yes | mkfs.ext4 ..." results in the error message results in > the test failing, at least for some versions of e2fsprogs: > > +yes: standard output: Broken pipe > +yes: write error > > It better to use the -F option, which will eliminate the questions. > > Signed-off-by: Theodore Ts'o <tytso@xxxxxxx> > Cc: Xiaoguang Wang <wangxg.fnst@xxxxxxxxxxxxxx> > Cc: Eryu Guan <eguan@xxxxxxxxxx> Looks good to me. Reviewed-by: Eryu Guan <eguan@xxxxxxxxxx> Thanks, Eryu > --- > tests/ext4/003 | 2 +- > tests/ext4/306 | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/ext4/003 b/tests/ext4/003 > index 572e685..a2e9d75 100755 > --- a/tests/ext4/003 > +++ b/tests/ext4/003 > @@ -43,7 +43,7 @@ _require_ext4_bigalloc > > rm -f $seqres.full > > -yes | mkfs.ext4 -O bigalloc -C 65536 -g 256 $SCRATCH_DEV 512m \ > +mkfs.ext4 -F -O bigalloc -C 65536 -g 256 $SCRATCH_DEV 512m \ > >> $seqres.full 2>&1 > _scratch_mount || _fail "couldn't mount fs" > > diff --git a/tests/ext4/306 b/tests/ext4/306 > index fd50b0e..fd5c3a2 100755 > --- a/tests/ext4/306 > +++ b/tests/ext4/306 > @@ -48,7 +48,7 @@ _require_scratch > rm -f $seqres.full > > # Make a small ext4 fs with extents disabled & mount it > -yes | mkfs.ext4 -O ^extents,^64bit $SCRATCH_DEV 512m >> $seqres.full 2>&1 > +mkfs.ext4 -F -O ^extents,^64bit $SCRATCH_DEV 512m >> $seqres.full 2>&1 > _scratch_mount || _fail "couldn't mount fs" > > # Create a small non-extent-based file > -- > 2.1.0 > > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
