Any comments on this cleanup patch? > From: Wang Shilong <wshilong@xxxxxxx> > > ext4_journal_get_write_access() has just been called in ext4_append() > calling it again here is duplicated. > > Signed-off-by: Wang Shilong <wshilong@xxxxxxx> > --- > fs/ext4/namei.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c > index 3520ab8..6d0d01f 100644 > --- a/fs/ext4/namei.c > +++ b/fs/ext4/namei.c > @@ -2390,10 +2390,6 @@ static int ext4_init_new_dir(handle_t *handle, struct inode *dir, > dir_block = ext4_append(handle, inode, &block); > if (IS_ERR(dir_block)) > return PTR_ERR(dir_block); > - BUFFER_TRACE(dir_block, "get_write_access"); > - err = ext4_journal_get_write_access(handle, dir_block); > - if (err) > - goto out; > de = (struct ext4_dir_entry_2 *)dir_block->b_data; > ext4_init_dot_dotdot(inode, de, blocksize, csum_size, dir->i_ino, 0); > set_nlink(inode, 2); > -- > 1.9.3 > Best Regards, Wang Shilong -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
