On Mon, Aug 11, 2014 at 10:09:35AM -0700, Darrick J. Wong wrote: > > Looking at the strace output, it looks like a bunch of pwrite/write calls are > returning -EBADF when it tries to write the group descriptors to a O_RDONLY > file descriptor. > > The call to ext2fs_flush() needs to be guarded by a "if (fs->flags & > EXT2_FLAG_DIRTY)" because ext2fs_flush() unconditionally writes out the group > descriptors. We don't want to do that unless the FS is actually dirty, and we > certainly don't want to do that for a RO check. Oops, I had forgotten that we didn't have such a check inside ext2fs_flush(). Thanks for catching this! - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
