Re: [PATCH v2] ext4: check inline directory before converting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Darrick J. Wong <darrick.wong <at> oracle.com> writes:

> +int ext4_check_all_de(struct inode *dir, struct buffer_head *bh, void 
*buf,
> +		      int buf_size)
> +{
> +	struct ext4_dir_entry_2 *de;
> +	int nlen, rlen;

Is nlen actually used in this function?

> +	unsigned int offset = 0;
> +	char *top;
> +
> +	de = (struct ext4_dir_entry_2 *)buf;
> +	top = buf + buf_size;
> +	while ((char *) de < top) {
> +		if (ext4_check_dir_entry(dir, NULL, de, bh,
> +					 buf, buf_size, offset))
> +			return -EIO;
> +		nlen = EXT4_DIR_REC_LEN(de->name_len);

It is set here, but its value is never used.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux